Closed
Conversation
2 tasks
c170705 to
99bb719
Compare
Contributor
|
IMO, we should not test the Engine API client implementations via CL tests. This should rather be done via Hive. Recalling my comment from the original PR and your reply:
I think the disposable TestEngine should be pretty much enough for CL tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #2637
It may be better to start with small changes rather than writing overcomplicated scripts.
1. Use validator guide helpers to generate the execution payload for
on_merge_blocktestsSee
run_get_execution_payload_with_mock_engine_get_payload.get_execution_payloadwould improve our test coverage a bit. 🙂 We can also create validator guide unit tests later in other PRs.2. Fork choice rule test format updates
This PR changes the existing fork choice tests output:
{'attestation': attestation_0x<attestation_root>}is now{'on_attestation': {'attestation': 'attestation_0x<attestation_root>'}}on_blockstep.pow_blockoutputget_pow_blockhelper is called.engine_executePayloadrequest and response withon_blockon_blockstep triggersprocess_execution_payloadandengine_executePayload:requestfields to verify if the request is as expected.responsefields as the return value of the given APIs.Minor fixes
prepare_payloadparameters in setup.pybuild_empty_execution_payload