Conversation
|
Re opaque transactions -- the intention is to type these with a union type so that multiple transaction types can be supported. "execution" is the more general and proper term imo |
Just to make sure I understand are you suggesting renaming every instance of "opaque transaction" to "execution transaction"? That would work for me :) |
Co-authored-by: Danny Ryan <[email protected]>
It's not a static module, it's a dynamic part of the environment, something that is plugged in like configuration. E.g. tests, testnets, mainnet, different eth1-redundancy setups, etc. may all use completely different execution engines through this same protocol. The upper-snake-case to match the config style was intentional. |
0f84664 to
0bf3f85
Compare
Polish
merge/beacon-chain.mdwith mostly non-substantive changes.Non-substantive changes
MAX_EXECUTION_TRANSACTIONStoMAX_TRANSACTIONS_PER_PAYLOADcompute_time_at_slottocompute_timestamp_at_slotexecution_payload.timestampExecutionEngine.execution_statefor clarityExecutionPayload.numbertoExecutionPayload.block_numberExecutionPayload.block_hashnew_blocktoon_payloadon_prefix is consistent with other event handlers (e.g. seeon_tick,on_block,on_attestationhere)_payloadsuffix is more to the point given the function accepts anexecution_payloadon_blockwhich is already used in the fork choiceis_execution_enabledafteris_transition_completedandis_transition_blockis_execution_enabledrefers tois_transition_completedandis_transition_blockprocess_execution_payloadprocess_execution_payloadsignature consistent with the otherprocess_functions inprocess_blockwhich take as argumentsstateandblock.bodyTRANSITION_TOTAL_DIFFICULTYmerge/fork-choice.mdwhere it is usedSubstantive changes
ExecutionPayloadfieldsExecutionPayloadHeader