Add support for github usernames in author lines#974
Merged
nicksavers merged 2 commits intoethereum:masterfrom Apr 6, 2018
Merged
Add support for github usernames in author lines#974nicksavers merged 2 commits intoethereum:masterfrom
nicksavers merged 2 commits intoethereum:masterfrom
Conversation
Contributor
|
It should be pretty obvious for editors that this refers to a GitHub username, but to any other reader it might look like a Twitter handle or another username. Is there a way to make this more obvious? Is it really something to be concerned about? |
Contributor
Author
|
Well, on the generated site it links to the GitHub page. |
Contributor
|
Examples already exist
I suppose it has already been established as an acceptable contact method and this pull request would just make use of it. |
nicksavers
approved these changes
Apr 6, 2018
|
ok |
Arachnid
added a commit
to Arachnid/EIPs
that referenced
this pull request
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.