Skip to content

Create EIP 191#973

Merged
Arachnid merged 1 commit intoethereum:masterfrom
Arachnid:191
Apr 5, 2018
Merged

Create EIP 191#973
Arachnid merged 1 commit intoethereum:masterfrom
Arachnid:191

Conversation

@Arachnid
Copy link
Contributor

@Arachnid Arachnid commented Apr 5, 2018

Replaces #191.

@Arachnid Arachnid requested a review from holiman April 5, 2018 12:41
@holiman
Copy link
Contributor

holiman commented Apr 5, 2018

Sgtm!

@3esmit
Copy link
Contributor

3esmit commented Apr 9, 2018

Can we make the signed data standard a "solidity default method", or we would have to stick to libraries? Maybe signHash(bytes32) return data signed in standard? or even make signHash accept multiple n arguments and make all easy? :)

Not sure if place to open another EIP for this or open some issue in solidity after this EIP is merged?

@Arachnid
Copy link
Contributor Author

Arachnid commented Apr 9, 2018

Opening an issue in Solidity would be best, but I'm not sure it's justified - keccak256('\x19\x00', this.address, data) works just fine.

Arachnid added a commit to Arachnid/EIPs that referenced this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants