Update EIP-4844: Update blob base fee to base fee per blob gas#8316
Merged
eth-bot merged 2 commits intoethereum:masterfrom Mar 29, 2024
Merged
Update EIP-4844: Update blob base fee to base fee per blob gas#8316eth-bot merged 2 commits intoethereum:masterfrom
eth-bot merged 2 commits intoethereum:masterfrom
Conversation
Collaborator
|
✅ All reviewers have approved. |
This was referenced Mar 14, 2024
g11tech
changed the title
KillariDev
approved these changes
Mar 21, 2024
g11tech
force-pushed
the
blobbasefee-pergas
branch
from
0764e1a to
543a298
Compare
16 tasks
lightclient
approved these changes
Mar 29, 2024
eth-bot
approved these changes
Mar 29, 2024
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blob base feerefereed in the EIP is actuallybase fee per blob gas, and seems to have confused quite a number of readers.calc_data_fee=>calc_bob_fee) going with the previous reasoning of renaming data => bob to not conflict with any future other "data" objects that can be addedThis EIP updates the same since it doesn't has any material change since no header fields are affected (and hence doesn't affect consensus), just internal helper functions and constants which clients can update at their own pace