Skip to content

Add EIP: Reuse Withdrawn Validator Indices#6914

Merged
eth-bot merged 13 commits intoethereum:masterfrom
djrtwo:patch-2
Oct 19, 2023
Merged

Add EIP: Reuse Withdrawn Validator Indices#6914
eth-bot merged 13 commits intoethereum:masterfrom
djrtwo:patch-2

Conversation

@djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 19, 2023

todo:

  • assign number
  • create discussions-to
  • rename consensus-specs feature directory to EIP name and fix outbound link

@djrtwo djrtwo requested a review from eth-bot as a code owner April 19, 2023 23:35
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Apr 19, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 19, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title create validator index reuse eip Add EIP: Reuse Withdrawn Validator Indices Apr 19, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 19, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 19, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 20, 2023
Co-authored-by: lightclient <[email protected]>
EIPS/eip-6914.md Outdated
title: Reuse Withdrawn Validator Indices
description: Reuse fully withdrawn and safe to reuse validator indices for new beacon chain deposits.
author: Lion (@dapplion), Danny Ryan (@djrtwo)
discussions-to: https://github.com/ethereum/consensus-specs/issues/3335
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that discussions-to MUST be eth magicians. Can we not use an issue on the spec repo? This is where organic conversation aroudn these specs already occurs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main concern is about deletion of the issue, but i guess can be waived for execution-specs and consensus-specs issues as those two repos can enforce non deletion

@eth-bot eth-bot changed the base branch from master to eipbot/6914 May 2, 2023 15:20
@eth-bot eth-bot changed the base branch from eipbot/6914 to master May 2, 2023 15:20
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 2, 2023
@@ -0,0 +1,77 @@
---
eip: draft_reuse_withdrawn_validator_indi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: draft_reuse_withdrawn_validator_indi
eip: 6914

Assigning EIP number as PR number. Please also update the filename.

@SamWilsn
Copy link
Contributor

I'll just need an author to confirm @g11tech's suggestion and I think this'll be good to merge.

@github-actions
Copy link

The commit 60fef4b (as a parent of 2d60b94) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 17, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀 🙂

@eth-bot eth-bot enabled auto-merge (squash) October 19, 2023 06:36
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants