Add EIP-6464: Multi-operator, per-token ERC721 approval by ARR4N · Pull Request #6464 · ethereum/EIPs

ARR4N · 2023-02-08T15:53:06Z

Abstract

The ERC721 standard did not foresee the approval of multiple operators to manage a specific token on behalf of its owner. This lead to the establishment of setApprovalForAll() as the predominant way to authorise operators, which affords the approved address control over all assets and creates an unnecessarily broad security risk that has already been exploited in a multitude of phishing attacks. The presented EIP extends ERC721 by introducing a fine-grained, on-chain approval mechanism that allows owners to authorise multiple, specific operators on a per-token basis; this removes unnecessary access permissions and shrinks the surface for exploits to a minimum. The provided reference implementation further enables cheap revocation of all approvals on a per-owner or per-token basis.

TL;DR

Extend ERC721 with setExplicitApproval(address operator, uint256 tokenId, bool approved) to allow NFT owners to avoid use of setApprovalForAll() when selling on multiple marketplaces.

eth-bot · 2023-02-08T15:54:16Z

All reviewers have approved. Auto merging...

ARR4N · 2023-02-09T14:57:56Z

We've addressed all linter issues, including eth-bot's (using the presumptive EIP number 6464 based on the PR; it's a nice number so we'd love to keep it if possible, please).

I'll try get eth-bot to rerun in another comment but am guessing permissions won't allow it :)

ARR4N · 2023-02-09T14:59:00Z

@eth-bot rerun

Pandapip1 · 2023-02-24T18:55:27Z

@eth-bot rerun

Pandapip1

Please rebase the branch. Your walidator version is outdated.

…1 approval."

…l()`.

…ater

* Rename files and directories to include EIP number * Address linter (`EIP Walidator`) issues * Add presumed EIP number based on PR: 6464 * Revert `.gitignore` to get through initial draft acceptance * Do the last commit properly ;) * Add ERC category

github-actions · 2023-02-25T10:07:46Z

The commit 7568b28 (as a parent of 38812c8) contains errors.
Please inspect the Run Summary for details.

Pandapip1

Please fix the walidator issues

ARR4N · 2023-02-26T17:42:37Z

@eth-bot rerun

ARR4N · 2023-02-26T17:45:58Z

Thanks for taking a look, @Pandapip1, all walidator issues have been addressed.

assets/eip-6464/contracts/IERC165.sol

assets/eip-6464/contracts/IERC6464.sol

assets/eip-6464/contracts/IERC721.sol

…; change 6464 license to CC0

ARR4N · 2023-02-28T09:58:57Z

I couldn't just swap out MIT for CC0 as those were OpenZeppelin versions, so I've replaced them with the originals from the EIPs themselves. Also changed ours to CC0 as requested.

EIPS/eip-6464.md

Pandapip1

I'm still not sure that I understand this, but it looks complete and has no obvious errors. Hopefully you can make this a bit clearer before Review.

ARR4N · 2023-03-03T20:20:19Z

I'm still not sure that I understand this, but it looks complete and has no obvious errors. Hopefully you can make this a bit clearer before Review.

Thanks for the reviews, @Pandapip1. Are we allowed to include lay descriptions in the Abstract? The template says it must be technical and very terse, but I think something like the following would go a long way to clarify:

The only way to sell NFTs on more than one marketplace simultaneously is to approve each marketplace to manage all of your tokens on a contract, not just the single token you wish to sell. This EIP introduces a fine-grained way to approve only specific token(s) and thus reduce the security risk from phishing scams that piggyback off marketplace contracts.

alexanderramos89

Those looks great thank you !

* EIP Motivation and Specification for "Multi-operator, per-token ERC721 approval." * Add remaining authors' names * Interface overhaul with explanation in EIP markdown. * Add `Abstract` and `@dev` note about interplay with `setApprovalForAll()`. * Partial response to cxkoda review * Full response to cxkoda review * Explicitly include OZ `IERC{165,721}.sol` instead of using a submodule * Minor typo and wording changes to draft. * Prune authors to active participants as they can always be re-added later * Revert `.gitignore` so as to not change it in the EIP draft (ethereum#7) * Set presumptive EIP number and fix linter complaints (ethereum#5) * Rename files and directories to include EIP number * Address linter (`EIP Walidator`) issues * Add presumed EIP number based on PR: 6464 * Revert `.gitignore` to get through initial draft acceptance * Do the last commit properly ;) * Add ERC category * Fix linter issues (ethereum#8) * Update EIP- references to ERC- * Remove OpenZeppelin interfaces and replace with original EIP versions; change 6464 license to CC0 * Add `solidity` language tag to code block

* EIP Motivation and Specification for "Multi-operator, per-token ERC721 approval." * Add remaining authors' names * Interface overhaul with explanation in EIP markdown. * Add `Abstract` and `@dev` note about interplay with `setApprovalForAll()`. * Partial response to cxkoda review * Full response to cxkoda review * Explicitly include OZ `IERC{165,721}.sol` instead of using a submodule * Minor typo and wording changes to draft. * Prune authors to active participants as they can always be re-added later * Revert `.gitignore` so as to not change it in the EIP draft (#7) * Set presumptive EIP number and fix linter complaints (#5) * Rename files and directories to include EIP number * Address linter (`EIP Walidator`) issues * Add presumed EIP number based on PR: 6464 * Revert `.gitignore` to get through initial draft acceptance * Do the last commit properly ;) * Add ERC category * Fix linter issues (#8) * Update EIP- references to ERC- * Remove OpenZeppelin interfaces and replace with original EIP versions; change 6464 license to CC0 * Add `solidity` language tag to code block

ARR4N requested a review from eth-bot as a code owner February 8, 2023 15:53

github-actions bot added the s-draft This EIP is a Draft label Feb 8, 2023

github-actions bot added the w-ci Waiting on CI to pass label Feb 8, 2023

ARR4N changed the title ~~Multi-operator, per-token ERC721 approval~~ Add EIP: Multi-operator, per-token ERC721 approval Feb 8, 2023

github-actions bot added c-new Creates a brand new proposal t-erc and removed w-ci Waiting on CI to pass labels Feb 8, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 24, 2023

Pandapip1 suggested changes Feb 24, 2023

View reviewed changes

github-actions bot added the w-ci Waiting on CI to pass label Feb 24, 2023

ARR4N and others added 12 commits February 25, 2023 11:01

EIP Motivation and Specification for "Multi-operator, per-token ERC72…

569bba0

…1 approval."

Add remaining authors' names

a9265d6

Interface overhaul with explanation in EIP markdown.

74dbf3b

Add Abstract and @dev note about interplay with `setApprovalForAl…

1ef88db

…l()`.

Partial response to cxkoda review

26ee190

Full response to cxkoda review

9935a2a

Explicitly include OZ IERC{165,721}.sol instead of using a submodule

e072772

Minor typo and wording changes to draft.

dfe2b88

Prune authors to active participants as they can always be re-added l…

b508b46

…ater

Revert .gitignore so as to not change it in the EIP draft (#7)

749689f

Fix linter issues (#8)

7568b28

Pandapip1 suggested changes Feb 26, 2023

View reviewed changes

alexanderramos89 previously approved these changes Feb 26, 2023

View reviewed changes

Update EIP- references to ERC-

fc8d0c4

ARR4N dismissed alexanderramos89’s stale review via fc8d0c4 February 26, 2023 17:38

github-actions bot removed the w-ci Waiting on CI to pass label Feb 26, 2023

ARR4N requested a review from Pandapip1 February 26, 2023 19:00

Pandapip1 suggested changes Feb 27, 2023

View reviewed changes

assets/eip-6464/contracts/IERC165.sol Outdated Show resolved Hide resolved

assets/eip-6464/contracts/IERC6464.sol Outdated Show resolved Hide resolved

assets/eip-6464/contracts/IERC721.sol Outdated Show resolved Hide resolved

Remove OpenZeppelin interfaces and replace with original EIP versions…

dea58dd

…; change 6464 license to CC0

ARR4N requested a review from Pandapip1 February 28, 2023 09:59

Pandapip1 reviewed Feb 28, 2023

View reviewed changes

EIPS/eip-6464.md Outdated Show resolved Hide resolved

Add solidity language tag to code block

9a5a082

ARR4N requested a review from Pandapip1 February 28, 2023 14:36

ARR4N changed the title ~~Add EIP: Multi-operator, per-token ERC721 approval~~ Add EIP-6464: Multi-operator, per-token ERC721 approval Feb 28, 2023

Pandapip1 approved these changes Mar 3, 2023

View reviewed changes

eth-bot enabled auto-merge (squash) March 3, 2023 18:56

eth-bot approved these changes Mar 3, 2023

View reviewed changes

eth-bot merged commit 607ec5d into ethereum:master Mar 3, 2023

alexanderramos89 reviewed Mar 3, 2023

View reviewed changes

Conversation

ARR4N commented Feb 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Abstract

TL;DR

Uh oh!

eth-bot commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ARR4N commented Feb 9, 2023

Uh oh!

ARR4N commented Feb 9, 2023

Uh oh!

Pandapip1 commented Feb 24, 2023

Uh oh!

Pandapip1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 25, 2023

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

ARR4N commented Feb 26, 2023

Uh oh!

ARR4N commented Feb 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ARR4N commented Feb 28, 2023

Uh oh!

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

ARR4N commented Mar 3, 2023

Uh oh!

alexanderramos89 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ARR4N commented Feb 8, 2023 •

edited by github-actions bot

Loading

eth-bot commented Feb 8, 2023 •

edited

Loading

Pandapip1 left a comment •

edited

Loading

alexanderramos89 left a comment •

edited

Loading