EIP-4895: CL-EL withdrawals harmonization: using units of Gwei#6325
Merged
eth-bot merged 3 commits intoethereum:masterfrom Jan 16, 2023
Merged
EIP-4895: CL-EL withdrawals harmonization: using units of Gwei#6325eth-bot merged 3 commits intoethereum:masterfrom
eth-bot merged 3 commits intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
|
A critical exception has occurred: |
timbeiko
reviewed
Jan 12, 2023
|
The commit 41224ef (as a parent of 4a3fd72) contains errors. |
yperbasis
previously approved these changes
Jan 13, 2023
djrtwo
previously approved these changes
Jan 13, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks good other than the lint error
This was referenced Jan 14, 2023
This was referenced Jan 14, 2023
etan-status
previously approved these changes
Jan 14, 2023
etan-status
added a commit
to etan-status/consensus-specs
that referenced
this pull request
Jan 15, 2023
Updates the EL block hash computation for pytests to match latest spec. Notably, use `Gwei` for `Withdrawal` amount consistently. Also fix `excess_data_gas` not being correctly accounted for. ethereum/execution-apis#354 ethereum/EIPs#6325
ralexstokes
dismissed stale reviews from etan-status, djrtwo, and yperbasis
via
09e26fe
eth-bot
approved these changes
Jan 16, 2023
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 17, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion from here ethereum/pm#702, protocol devs want to explore harmonization in the withdrawals format from CL to EL.
This PR updates EIP-4895 with the first part of this change to use the same units (
Gwei) for theamountin each withdrawal.