Skip to content

Add EIP-6051: Private Key Encapsulation#6051

Merged
eth-bot merged 39 commits intoethereum:masterfrom
Base-Labs:master
Dec 27, 2022
Merged

Add EIP-6051: Private Key Encapsulation#6051
eth-bot merged 39 commits intoethereum:masterfrom
Base-Labs:master

Conversation

@weiji-cryptonatty
Copy link
Contributor

@weiji-cryptonatty weiji-cryptonatty commented Nov 28, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@weiji-cryptonatty weiji-cryptonatty changed the title Added EIP for private key encapsulation Added EIP-6051 for private key encapsulation Nov 28, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 28, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 6051 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Nov 28, 2022
@Pandapip1 Pandapip1 changed the title Added EIP-6051 for private key encapsulation Add EIP-6051: private key encapsulation Nov 28, 2022
@Pandapip1 Pandapip1 changed the title Add EIP-6051: private key encapsulation Add EIP-6051: Private Key Encapsulation Nov 28, 2022
@poojaranjan poojaranjan mentioned this pull request Nov 29, 2022
Closed
xinbenlv
xinbenlv reviewed Nov 29, 2022
View reviewed changes
xinbenlv
xinbenlv reviewed Nov 29, 2022
View reviewed changes
xinbenlv
xinbenlv reviewed Nov 29, 2022
View reviewed changes
xinbenlv
xinbenlv reviewed Nov 29, 2022
View reviewed changes
xinbenlv
xinbenlv reviewed Nov 29, 2022
View reviewed changes
@weiji-cryptonatty
Copy link
Contributor Author

weiji-cryptonatty commented Nov 30, 2022

Hi @xinbenlv I had pushed some more commits to address all issues except the ERC vs Interface. Could you please review again? Thanks a lot.

@weiji-cryptonatty
Copy link
Contributor Author

weiji-cryptonatty commented Dec 9, 2022

These are my main editorial review comments, many of them are due to the grammar issue. I totally understand grammar challenge myself because I speak English as second language. Please consider run via a grammar checker.

Another major issue is to keep it consistent for terminologies that you specifically defined. For example, when addressing "Recipient" or "Sender", please capitalize.

Hi @xinbenlv thank you again for the very careful and very detailed reviews. I can see why EIP editors are so overwhelmed. I really appreciate what you had done here.

I think I have fixed all issues. I also ran another round with grammarly.com and fixed almost all issues it suggests (with very few I did not agree with it). Please review again when you do find time.

@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 9, 2022 •
edited
Loading

From a technical perspective, I personally still think, if the EIP is defining a way to encapsulate and unwrap private key via eth_ interface, that is considered an interface category, but we can address it later.

xinbenlv
xinbenlv previously approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge as a draft now. Defer to @Pandapip1 @SamWilsn to follow up the merging.

@weiji-cryptonatty weiji-cryptonatty mentioned this pull request Dec 20, 2022
Closed
12 tasks
Pandapip1
Pandapip1 suggested changes Dec 21, 2022
View reviewed changes
weiji-cryptonatty
weiji-cryptonatty commented Dec 22, 2022
View reviewed changes
Copy link
Contributor Author

@weiji-cryptonatty weiji-cryptonatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions accepted

@weiji-cryptonatty @Pandapip1
Update EIPS/eip-6051.md
716148d 
Co-authored-by: Pandapip1 <[email protected]>
Pandapip1
Pandapip1 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a draft

@eth-bot eth-bot enabled auto-merge (squash) December 27, 2022 14:58
@eth-bot eth-bot merged commit e666b5b into ethereum:master Dec 27, 2022
diogojoaquim
diogojoaquim reviewed Jul 12, 2025
View reviewed changes
Copy link

@diogojoaquim diogojoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eth-bot eth-bot eth-bot approved these changes

+3 more reviewers

@diogojoaquim diogojoaquim diogojoaquim left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@xinbenlv xinbenlv xinbenlv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-new Creates a brand new proposal s-draft This EIP is a Draft t-interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weiji-cryptonatty @eth-bot @xinbenlv @Pandapip1 @diogojoaquim