Updates to EIPs 2464 and 2364.#4395
Conversation
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
|
All tests passed; auto-merging... |
MicahZoltu
left a comment
MicahZoltu
left a comment
There was a problem hiding this comment.
Overall looks good. Still has a couple external links that should be removed, and I do strongly recommend adding yourself as an author so we can take these to the finish line in a timely fashion.
Signed-off-by: Tim Beiko <[email protected]>
Head branch was pushed to by a user without write access
|
Should have addressed your comments, @MicahZoltu! Would like @karalabe to approve before we merge given these are his EIPs and the modifications are a bit more extensive than I'd planned. |
|
There's also the |
|
Both appear to have a backward compatibility section. |
|
Apparently I don't have authority to approve this anymore! See #4418 to fix that, in the meantime @lightclient or @axic approving should result in auto-merge. |
Hmm, correct. The diff view was expanding weirdly yesterday. |
| ## Rationale | ||
|
|
||
| ##### EIP-2124 mentions advertising the `forkid` in the discovery protocol too. How does that compare to advertising in the `eth` protocol? Why is the redundancy needed? | ||
| The specification is tiny since most parts are already specified in EIP-2124. `eth/63` is not specified as an EIP, but is maintained [here](https://github.com/ethereum/devp2p/blob/master/caps/eth.md). |
There was a problem hiding this comment.
Not sure why this needs to be here? Is this the way to make @MicahZoltu allow an external URL? :)
There was a problem hiding this comment.
And can this URL be a tagged one, and not master?
There was a problem hiding this comment.
Ah, you are right, that should be removed. It is not necessary for the specification.
* Update offset and calculations Signed-off-by: Tim Beiko <[email protected]> * change title Signed-off-by: Tim Beiko <[email protected]> * add review-period-end Signed-off-by: Tim Beiko <[email protected]> * Remove review period Signed-off-by: Tim Beiko <[email protected]> * Add tjayrush as author Signed-off-by: Tim Beiko <[email protected]> * Changes from Pooja and Micah Signed-off-by: Tim Beiko <[email protected]> * Requested changes Signed-off-by: Tim Beiko <[email protected]>
5 participants
Combines the updates from #4367 and #4366, and addresses most comments from @MicahZoltu in a way which hopefully makes him happy, but recognizes the fact that these EIPs are already "ancient". Addressed all comments which were related to formatting/sections, but links are still present, and the specification has been left as is.
Hopefully we can get a soft +1 on these before requiring Péter to review & approve.