move eip-2464 from "stagnant" to "review"#4367
move eip-2464 from "stagnant" to "review"#4367poojaranjan wants to merge 1 commit intoethereum:masterfrom poojaranjan:BR32
Conversation
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): eip-2464.md
|
abcoathup
left a comment
abcoathup
left a comment
There was a problem hiding this comment.
This looks like Peter is two authors rather than providing email and GitHub contact details
This is the mechanism we use when one author would like both their GitHub handle and email address listed. Doing it any other way breaks our automation/tooling. |
MicahZoltu
left a comment
MicahZoltu
left a comment
There was a problem hiding this comment.
Test Cases section should be removed if there are no test cases. It is an optional section.
Security Considerations section is missing but is required for all EIPs.
Recommend moving all but the last paragraph of the Abstract into the Motivation. The abstract should just be a succinct human readable summary of the specification and should not go into the why at all.
Implementation isn't an EIP section so should be removed (also, external links should be removed). Reference Implementation is a section, but should include an inline implementation (usually pseudocode) or a link to something in ../assets/eip-2464. In this case, I recommend just removing the section entirely.
| @@ -1,9 +1,9 @@ | |||
| --- | |||
| eip: 2464 | |||
| title: "eth/65: transaction announcements and retrievals" | |||
There was a problem hiding this comment.
| title: "eth/65: transaction announcements and retrievals" | |
| title: "eth/65: transaction announcements and retrievals" | |
| description: Introduces `NewPooledTransactionHashes`, `GetPooledTransactions`, and `PooledTransactions`. |
description is a new required field (replaces Simple Summary).
|
@poojaranjan @MicahZoltu I've tried to address all concerns in #4395 so we can have a single PR to merge. |
|
Closing in favor of #4395 |
Pull request was closed
5 participants
No description provided.