Move eip-2364 from "stagnant" to "review"#4366
Move eip-2364 from "stagnant" to "review"#4366poojaranjan wants to merge 2 commits intoethereum:masterfrom poojaranjan:BR31
Conversation
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): eip-2364.md
|
MicahZoltu
left a comment
There was a problem hiding this comment.
Abstract should be cleaned up to just be a human readable summary of the specification, and not include rational/motivation related content.
First line of the specification should be removed or moved to the rationale. The specification should be only the technical specification and not include reasoning/arguments.
The subheadings under the Rationale section should be ### not #### so automatic table of contents don't break or render incorrectly.
Security Considerations section is missing but required.
Implementation section should be removed as it is not an EIP section. Reference Implementation is a valid section but should contain an inline implementation (usually pseudocode).
Test Cases section should include inline test cases, not a link to another repository. Note that Test Cases section is optional, so you are welcome to leave it out or just include the first line (which references tests in EIP-2124).
Head branch was pushed to by a user without write access
Incorporating new format suggestions. Co-authored-by: Micah Zoltu <[email protected]>
|
@poojaranjan @MicahZoltu I've tried to address all concerns in #4395 so we can have a single PR to merge. |
|
Closing in favor of #4395 |
Pull request was closed
No description provided.