Skip to content

Move eip-2364 from "stagnant" to "review"#4366

Closed
poojaranjan wants to merge 2 commits intoethereum:masterfrom
poojaranjan:BR31
Closed

Move eip-2364 from "stagnant" to "review"#4366
poojaranjan wants to merge 2 commits intoethereum:masterfrom
poojaranjan:BR31

Conversation

@poojaranjan
Copy link
Contributor

No description provided.

@eth-bot eth-bot enabled auto-merge (squash) October 14, 2021 15:38
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 14, 2021

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


eip-2364.md

Copy link
Contributor

@abcoathup abcoathup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like Peter is two authors rather than providing email and GitHub contact details
Micah explained this is due to automatic tooling implementation

Copy link

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstract should be cleaned up to just be a human readable summary of the specification, and not include rational/motivation related content.

First line of the specification should be removed or moved to the rationale. The specification should be only the technical specification and not include reasoning/arguments.

The subheadings under the Rationale section should be ### not #### so automatic table of contents don't break or render incorrectly.

Security Considerations section is missing but required.

Implementation section should be removed as it is not an EIP section. Reference Implementation is a valid section but should contain an inline implementation (usually pseudocode).

Test Cases section should include inline test cases, not a link to another repository. Note that Test Cases section is optional, so you are welcome to leave it out or just include the first line (which references tests in EIP-2124).

auto-merge was automatically disabled October 15, 2021 13:47

Head branch was pushed to by a user without write access

Incorporating new format suggestions.

Co-authored-by: Micah Zoltu <[email protected]>
@eth-bot eth-bot enabled auto-merge (squash) October 15, 2021 13:47
@timbeiko
Copy link
Contributor

@poojaranjan @MicahZoltu I've tried to address all concerns in #4395 so we can have a single PR to merge.

@poojaranjan
Copy link
Contributor Author

Closing in favor of #4395

@poojaranjan poojaranjan closed this Nov 2, 2021
auto-merge was automatically disabled November 2, 2021 16:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants