Skip to content

Add simple summary to eip-1#3565

Closed
lightclient wants to merge 3 commits intoethereum:masterfrom
lightclient:add-simple-summary
Closed

Add simple summary to eip-1#3565
lightclient wants to merge 3 commits intoethereum:masterfrom
lightclient:add-simple-summary

Conversation

@lightclient
Copy link
Member

@lightclient lightclient commented May 10, 2021

For quite a while, simple summary has been an optional section in EIPs. This formalizes that in EIP-1. This would close #3564.

@lightclient lightclient force-pushed the add-simple-summary branch from 8ab902a to 92a1a2d Compare May 10, 2021 20:33
@alita-moore
Copy link
Contributor

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - eip-1.md is in state living, not draft or last call or review
 - eip-1.md requires approval from one of ([email protected], [email protected])

Each EIP should have the following parts:

- Preamble - RFC 822 style headers containing metadata about the EIP, including the EIP number, a short descriptive title (limited to a maximum of 44 characters), and the author details. See [below](./eip-1.md#eip-header-preamble) for details.
- Simple Summary (*optional) - A short (~1 sentence) non-technical summary of the EIP.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been enforcing this as non-optional. What is the argument for optionality? Having it required means that someone building a table of EIPs can rely on its presence for a sub-title/short description.

Copy link
Member Author

@lightclient lightclient May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small EIP generally don't benefit both (e.g. EIP-3541). I don't think there is much value in someone building a table of EIPs with short summaries, because I'd like to move away from EIPs as they are today anyways.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with your desire to move away from EIPs in general, I am concerned that such things won't come to fruition for quite some time due to resource constraints. I'm hesitant to make decisions that assume "this repository is dying anyway, we don't need to worry about long term maintenance/planning" until such time as there is a clear end of life schedule for it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3564 (comment) for my argument for why I believe Simple Summary is valuable even when it mirrors the Abstract. If anything, I would rather remove the Abstract in the case of duplication, though I believe that having both is valuable even if they overlap.

@github-actions
Copy link

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Jul 17, 2021
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jul 24, 2021
@axic
Copy link
Member

axic commented Nov 11, 2021

This was replaced by #3706.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants