Skip to content

fixed JSON parse errors#3112

Merged
MicahZoltu merged 1 commit intoethereum:masterfrom
SCBuergel:patch-1
Nov 14, 2020
Merged

fixed JSON parse errors#3112
MicahZoltu merged 1 commit intoethereum:masterfrom
SCBuergel:patch-1

Conversation

@SCBuergel
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@MicahZoltu MicahZoltu closed this Nov 12, 2020
@MicahZoltu MicahZoltu reopened this Nov 12, 2020
@MicahZoltu MicahZoltu closed this Nov 13, 2020
@MicahZoltu MicahZoltu reopened this Nov 13, 2020
@MicahZoltu
Copy link

Unfortunately all of the authors of this PR have email addresses rather than GitHub user names so I suspect that is why the bot isn't pinging them for approval.

That being said, this is a non-normative change that improves the correctness of the code block in question which is marked as json (not jsonc) and trailing commas are not allowed in JSON so I'm going to merge it. If any of the authors does eventually show up and desires it changed back we can make that happen.

@MicahZoltu MicahZoltu merged commit 3b2d80e into ethereum:master Nov 14, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
This was referenced Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants