EIP-2602: Disable null hash message verification for ecrecover precompile#2602
EIP-2602: Disable null hash message verification for ecrecover precompile#2602sorpaas wants to merge 5 commits intoethereum:masterfrom
Conversation
sorpaas
changed the title
sorpaas
changed the title
| @@ -0,0 +1,50 @@ | |||
| --- | |||
| eip: 2602 | |||
| title: Disable null hash message verification for ecrecover precompile | |||
There was a problem hiding this comment.
| title: Disable null hash message verification for ecrecover precompile | |
| title: Disable null hash message verification in the ecrecover precompile |
Since you use this wording below.
|
|
||
| ## Specification | ||
|
|
||
| In the beginning of execution of `ecrecover` precompile, fetch the message and check if it is equal to null hash (`0x0000...0000`). If so, set output length to `0` and return. |
There was a problem hiding this comment.
Can this specification a bit more extended? Should clarify if "message" here means a part of the input to the precompile or the entire input?
Also probably spelling out the entire hash is fine as that would signal how many bits it is (256?).
|
@sorpaas can you please respond? It would be nice to clarify the above and merge this. |
|
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
2 participants
Disable null hash message
ecrecoveroperation in the precompile, due to it being potentially unsafe.