Add discussion URL metadata to EIP-721#2434
Merged
axic merged 2 commits intoethereum:masterfrom Dec 15, 2019
Merged
Conversation
14 tasks
axic
reviewed
Dec 15, 2019
EIPS/eip-721.md
Outdated
| eip: 721 | ||
| title: ERC-721 Non-Fungible Token Standard | ||
| author: William Entriken <[email protected]>, Dieter Shirley <[email protected]>, Jacob Evans <[email protected]>, Nastassia Sachs <[email protected]> | ||
| discussions-to: https://github.com/ethereum/EIPs/pull/841 |
Member
There was a problem hiding this comment.
EIP-1 states the URL can't be a PR.
Contributor
Author
|
Thank you. Updated to the issue URL. |
axic
changed the title
axic
approved these changes
Dec 15, 2019
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
This only adds the long existing discussion URL to the finalized EIP-721.
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: