Skip to content

Use solidity/javascript highlighting in various EIPs#2372

Merged
axic merged 4 commits intoethereum:masterfrom
fulldecent:fix-fences-1062
Nov 22, 2019
Merged

Use solidity/javascript highlighting in various EIPs#2372
axic merged 4 commits intoethereum:masterfrom
fulldecent:fix-fences-1062

Conversation

@fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Nov 12, 2019

Simple fix

@fulldecent fulldecent mentioned this pull request Nov 12, 2019
Closed
@axic axic changed the title Fix fences Use solidity/javascript highlighting in EIP-1062 Nov 12, 2019
@axic
Copy link
Member

axic commented Nov 12, 2019

@fulldecent how about creating one PR to fix highlighting and we can just merge that?

@fulldecent
Copy link
Contributor Author

fulldecent commented Nov 12, 2019

I will do that next. Wanted to make sure this got through before I started on that.

@axic
Copy link
Member

axic commented Nov 12, 2019

Do you want to use this PR for that? I'll merge #2373.

@fulldecent
Copy link
Contributor Author

fulldecent commented Nov 12, 2019

@axic You got it. This PR is now comprehensive. Ready for review.

@eip-automerger
Copy link

eip-automerger commented Nov 12, 2019 •
edited
Loading

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

bitcoinbrisbane
bitcoinbrisbane approved these changes Nov 12, 2019
View reviewed changes
EIPS/eip-1753.md

### Solidity Example
```
```solidity
Copy link
Contributor

@bitcoinbrisbane bitcoinbrisbane Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@axic axic changed the title Use solidity/javascript highlighting in EIP-1062 Use solidity/javascript highlighting in various EIPs Nov 13, 2019
kashishkhullar
kashishkhullar approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@kashishkhullar kashishkhullar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

axic
axic reviewed Nov 17, 2019
View reviewed changes
EIPS/eip-233.md

```
```markdown
{% raw %}
Copy link
Member

@axic axic Nov 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, given it has this "raw" modifier?

Copy link
Contributor Author

@fulldecent fulldecent Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Linguist has improved to support Front Matters in ` markdown.

But thanks for pointing out -- cleaned up at dce9af3

Copy link
Member

@axic axic Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle this file in a separate PR? I'm not sure what is the good solution for it, but don't want to delay this PR.

@fulldecent
Copy link
Contributor Author

fulldecent commented Nov 22, 2019

@axic Done. It's updated at 59bc971

axic
axic approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is nice because it improves rendering.

@axic axic merged commit af677b3 into ethereum:master Nov 22, 2019
@fulldecent fulldecent deleted the fix-fences-1062 branch November 23, 2019 01:38
CarlBeek added a commit to CarlBeek/EIPs that referenced this pull request Nov 26, 2019
@CarlBeek
Merge branch 'bls_keystore' of github.com:CarlBeek/EIPs into bls_keys…
39caeca 
…tore

* 'bls_keystore' of github.com:CarlBeek/EIPs: (47 commits)
  fix link to heading
  Fix spelling
  Fix email address
  Draft EIP: BLS12-381 Deterministic Account Hierarchy (ethereum#2334)
  Fix some URLs and require 2333 too
  Add name to metadata title (ethereum#2370)
  Draft: BLS12-381 Key Generation (ethereum#2333)
  Automatically merged updates to draft EIP(s)  (ethereum#2397)
  Hard fork proposal to address the Ice age (ethereum#2387)
  Automatically merged updates to draft EIP(s) 1767 (ethereum#2262)
  EIP-2021: Payoutable Token (ethereum#2021)
  EIP-2009: Compliance Service (ethereum#2009)
  EIP-2019: Fundable Token (ethereum#2019)
  Use solidity/javascript highlighting in various EIPs (ethereum#2372)
  EIP-2018: Clearable Token (ethereum#2018)
  EIP-1996: Holdable token (ethereum#1996)
  Fix the username of @pizza-r0b in EIP-2309 (ethereum#2389)
  Clarify that empty accounts also return 0 in EIP-1052 (ethereum#2388)
  dType Functions Extension - Decentralized Type System for EVM (ethereum#2267)
  Fix spelling of GitHub [R4R] (ethereum#2369)
  ...
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@fulldecent @tkstanczak
Use solidity/javascript highlighting in various EIPs (ethereum#2372)
08cafe1
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@fulldecent @Arachnid
Use solidity/javascript highlighting in various EIPs (ethereum#2372)
4b1746c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@axic axic axic approved these changes

@3esmit 3esmit 3esmit approved these changes

@bitcoinbrisbane bitcoinbrisbane bitcoinbrisbane approved these changes

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@kashishkhullar kashishkhullar kashishkhullar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fulldecent @axic @eip-automerger @3esmit @bitcoinbrisbane @SebastianElvis @kashishkhullar