Skip to content

Add reference to affected EIP#2251

Merged
eip-automerger merged 2 commits intoethereum:masterfrom
fulldecent:patch-43
Aug 31, 2019
Merged

Add reference to affected EIP#2251
eip-automerger merged 2 commits intoethereum:masterfrom
fulldecent:patch-43

Conversation

@fulldecent
Copy link
Contributor

Adding reference for backwards compatibility issue on affected EIP

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1884 requires approval from one of (@holiman)

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some info, I didn't know about that myself. I'd like to add some more detailed analysis. cc @Arachnid , PTAL if this seems correct

Co-Authored-By: Martin Holst Swende <[email protected]>
@fulldecent
Copy link
Contributor Author

@holiman looks great, thank you, added

@eip-automerger eip-automerger merged commit 7c5b41d into ethereum:master Aug 31, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
BelfordZ pushed a commit to BelfordZ/EIPs that referenced this pull request Dec 13, 2019
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants