Skip to content

EIP-1: clarify the process around core EIPs#2196

Merged
nicksavers merged 2 commits intoethereum:masterfrom
axic:eip-1-accepted
Sep 18, 2019
Merged

EIP-1: clarify the process around core EIPs#2196
nicksavers merged 2 commits intoethereum:masterfrom
axic:eip-1-accepted

Conversation

@axic
Copy link
Member

@axic axic commented Jul 17, 2019

This PR has two parts:

  1. attempts to document the current process around Core EIPs a bit better
  2. renames Accepted to Ready

On https://gitter.im/ethereum/EIPs there was a discussion about the Accepted state being misleading. Some new names were proposed: Reviewed, Stable, Live.

I think Ready is the best way to describe this status. It is ready to be reviewed by the "All Core Devs" and consider it for inclusion in a protocol update.

@axic
Copy link
Member Author

axic commented Jul 17, 2019

Perhaps I should separate the renaming so that the clarification of EIP-1 wording can be merged sooner.

@fulldecent
Copy link
Contributor

I fully support this PR and I am the last author of a lot of the lines that are being updated.

@axic
Copy link
Member Author

axic commented Jul 19, 2019

@chriseth suggested Complete for the same state here, while @fubuloubu suggested introducing a new state Review prior to Last Call here.

I'm leaning towards this PR is a good middle ground and close enough what happens right now, but clarifies the states better.

@axic
Copy link
Member Author

axic commented Sep 10, 2019

@Arachnid @nicksavers @Souptacular @gcolvin any comments?

@axic
Copy link
Member Author

axic commented Sep 15, 2019

Rebased after #2236.

@axic axic changed the title EIP-1: clarify the process around core EIPs and rename Accepted to Ready EIP-1: clarify the process around core EIPs Sep 16, 2019
@axic
Copy link
Member Author

axic commented Sep 16, 2019

@nicksavers split out the renaming to make this eaiser, we can argue about renaming and the process to do the renaming in #2279.

@nicksavers nicksavers merged commit 3fe4229 into ethereum:master Sep 18, 2019
@axic axic deleted the eip-1-accepted branch September 18, 2019 15:40
@Arachnid
Copy link
Contributor

"Final" is the state where something is ready to be reviewed for inclusion by All Core Devs. Why are we introducing another status?

@axic
Copy link
Member Author

axic commented Sep 26, 2019

"Final" is the state where something is ready to be reviewed for inclusion by All Core Devs.

It's not. This is what it originally said:

Accepted (Core EIPs only) -- This EIP is in the hands of the Ethereum client developers. Their process for deciding whether to encode it into their clients as part of a hard fork is not part of the EIP process.

➡️ Final -- Standards Track Core EIPs must be implemented in at least three viable Ethereum clients before it can be considered Final. When the implementation is complete and adopted by the community, the status will be changed to “Final”.

It explicitly says that ACD looks at it at the Accepted stage and may consider moving it to the Final stage.

ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants