Conversation
| at the address being the remaining 160 bits. | ||
|
|
||
| In case the account does not exist `0` is pushed to the stack. | ||
| In case the account does not exist or is empty `0` is pushed to the stack. |
There was a problem hiding this comment.
Did you mean it's bytecode empty or is there another notion of emptyness?
| In case the account does not exist or is empty `0` is pushed to the stack. | |
| In case the account does not exist or the bytecode is empty `0` is pushed to the stack. |
There was a problem hiding this comment.
We’re using EIP-161’s definition of “empty” here — having no nonce, balance or code.
There was a problem hiding this comment.
Shouldn't it note as a comment that EIP-161's definition is used?
There was a problem hiding this comment.
Yes, I'd like to have this comment as well. Something like
or is empty (as defined by EIP-161)
|
@chfast is it clear to merge? |
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
Sorry for long wait. I planned to add more tests for this case.
| at the address being the remaining 160 bits. | ||
|
|
||
| In case the account does not exist `0` is pushed to the stack. | ||
| In case the account does not exist or is empty `0` is pushed to the stack. |
There was a problem hiding this comment.
| In case the account does not exist or is empty `0` is pushed to the stack. | |
| In case the account does not exist or is empty (as defined by [EIP-161](https://eips.ethereum.org/EIPS/eip-161)) `0` is pushed to the stack. |
There was a problem hiding this comment.
It seems @sorpaas has disabled maintainers' access to his fork. Will need to create a new PR.
| at the address being the remaining 160 bits. | ||
|
|
||
| In case the account does not exist `0` is pushed to the stack. | ||
| In case the account does not exist or is empty `0` is pushed to the stack. |
5 participants
Errata to clarify EIP-1052's behavior in case it meets with EIP-161's empty account. Geth/Aleth is having this behavior already. Parity previously will return
keccak([])for empty accounts, and now changed to return0x0as well in openethereum/parity-ethereum#10775Related to test
stExtCodeHash/codeCopyZero.