EIP-1716 Hardfork Meta: Petersburg (a.k.a. "Constantinople Fix")#1716
EIP-1716 Hardfork Meta: Petersburg (a.k.a. "Constantinople Fix")#17165chdn wants to merge 10 commits intoethereum:masterfrom
Conversation
Fast-forward upstream.
| - `Block >= 4_939_394` on the Ropsten testnet | ||
| - Removed EIPs: | ||
| - [EIP 1283](./eip-1283.md): Net gas metering for SSTORE without dirty maps | ||
|
|
There was a problem hiding this comment.
Potential clarifications:
- If
PetersburgandConstantinopleare applied at the same block,Petersburgtakes precedence: with the net effect of EIP 1283 being disabled. - If
Petersburgis defined with an earlier block number thanConstantinople, then there is no immediate effect from thePetersburgfork. However, whenConstantinopleis later activated, EIP-1283 should be disabled.
There was a problem hiding this comment.
Isn't it easier to state Petersburg can only be applied after Constantinople, with the one exception of activating at the same time, then Petersburg takes preference?
There was a problem hiding this comment.
I agree with @axic It will better if we can set Petersburg block number >= Constantinople
There was a problem hiding this comment.
It makes it unnecessary complicated. The clarification Martin proposed clearly states how a client should behave if Petersburg < Constantinople.
There was a problem hiding this comment.
I beg to differ. With allowing Petersburg before Constantinople the client must track a flag, while my proposal would allow the client to just reject starting after parsing the block numbers in the configuration.
There was a problem hiding this comment.
Well, the flag needs to be tracked regardless. With the proposed solution, we don't have to add an extra constraint when validating the configuration. It also makes it easier to manually/semi-manually create configurations, since you can set the petersburg block to 0 and don't worry about moving that one around if you move constantinople.
Also, geth has override.constantinople flag, which would continue to work nicely (and I'd recommend Parity to implement it too). If we change like you propose, the user would have to override both.
There was a problem hiding this comment.
Wouldn't it be better to specify it that Petersburg activates EIP 145, 1014, 1052, 1234 and disables 1283?
There was a problem hiding this comment.
No, Constantinople enables EIP 145, 1014, 1052, 1234, and 1283; Petersfork disables 1283. I don't see why we should have two hardforks for the same thing.
|
Will that make the "Petersburg" its official name? |
|
@5chdn why did you close this? I think this one should be merged. |
Abstract
This meta-EIP specifies the changes included in the Ethereum hardfork that removes EIP-1283 from Constantinople.