Skip to content

EIP-1707: Use Version Byte Prefix for Contract Account Versioning#1707

Closed
sorpaas wants to merge 7 commits intoethereum:masterfrom
sorpaas:sp-code-prefix
Closed

EIP-1707: Use Version Byte Prefix for Contract Account Versioning#1707
sorpaas wants to merge 7 commits intoethereum:masterfrom
sorpaas:sp-code-prefix

Conversation

@sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Jan 17, 2019 •
edited
Loading

(See https://specs.that.world/26-ver/ for the newest version of the spec.)

Provide an alternative proposal compared with EIP-1702 / ECIP-1040, with the following advantages:

  • We don't need to modify existing account state format.
  • We don't need to modify how precompiled contracts are invoked.
  • Compatible with the standard WebAssembly binary format.

@sorpaas sorpaas changed the title EIP-xxx: Use Version Byte Prefix for Contract Account Versioning EIP-1707: Use Version Byte Prefix for Contract Account Versioning Jan 17, 2019
@axic
Copy link
Member

axic commented Jan 17, 2019

Please also check #154. I have another pending EIP for defining the actual version numbers.

@sorpaas sorpaas mentioned this pull request Mar 4, 2019
Closed
@meowsbits meowsbits mentioned this pull request Mar 11, 2019
Closed
@sorpaas sorpaas mentioned this pull request Apr 25, 2019
Closed
@axic axic added the istanbul label May 19, 2019
axic
axic suggested changes May 22, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase to bring in new CI checks?

Please also add the missing sections (Abstract, Motivation, Rationale, Test Cases, Implementaiton).

@axic axic added the EIP label Jun 20, 2019
@axic
Copy link
Member

axic commented Jun 28, 2019

@sorpaas you can also mark this "Abandoned", but since there were so many discussions about versioning I'd suggest we do merge this.

@sorpaas
Copy link
Contributor Author

sorpaas commented Jun 28, 2019

@axic Done! I also added a superseded-by tag to 1702, to indicate that this proposal is dropped in favor of 1702 which serves the same functionality. Not sure if we have a better tag.

@sorpaas
Copy link
Contributor Author

sorpaas commented Jun 28, 2019

@axic CI returns this error:

EIPS/eip-1707.md is NOT valid:	 {:status=>["is not included in the list"]}

Apparently Abandoned status has not yet been added to the automerger bot.

@axic
Copy link
Member

axic commented Jun 28, 2019

Yes, it is being fixed :(

@axic
Copy link
Member

axic commented Jul 1, 2019

Will be fixed by #2161.

@sorpaas Can you add an "Abstract"? And the other missing sections, where you can just ad TBD.

@axic
Copy link
Member

axic commented Jul 2, 2019 •
edited
Loading

@sorpaas Abandoned is now accepted if you forward to master, but please address the above comments too.

@sorpaas
Copy link
Contributor Author

sorpaas commented Jul 3, 2019

@axic Sorry for the delay. I'll get this done soon.

@axic axic removed the istanbul label Jul 4, 2019
@axic axic mentioned this pull request Nov 4, 2019
Closed
@sorpaas
Copy link
Contributor Author

sorpaas commented Nov 6, 2019

I have decided to withdraw this for EIP publication due to licensing requirements. The newest version of this spec can be seen here: https://specs.that.world/26-ver/

@sorpaas sorpaas closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axic axic axic requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sorpaas @axic