Fix Last Call, remove jekyll-feeds plugin#1687
Merged
Arachnid merged 2 commits intoethereum:masterfrom Jan 11, 2019
Merged
Conversation
… in the RSS feed, including the discussion-to or Github issue link
This was referenced Jan 10, 2019
Arachnid
approved these changes
Jan 11, 2019
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
* Removed jekyll-feed plugin -- it only works on posts, EIPs are created as pages * Edited Last Call feed to work, and to have a header with EIP metadata in the RSS feed, including the discussion-to or Github issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix to make Last Call feed work.
I am also going to propose changes to fix #1535 and some additional feeds (e.g. global feed for all EIPs, JSON version of EIPs, etc. etc.)
I'll file a separate issue to gather suggestions for feed updates / wishlist.