Update EIP-8024: bytecode is missing one 0x6000 to match test case + description#11200
Closed
fselmo wants to merge 1 commit intoethereum:masterfrom
Closed
Update EIP-8024: bytecode is missing one 0x6000 to match test case + description#11200fselmo wants to merge 1 commit intoethereum:masterfrom
fselmo wants to merge 1 commit intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
File
|
eth-bot
changed the title
Contributor
Author
|
Hmm no something is off about the expected output. I'm closing this for now, will dig deeper. |
Contributor
I hear you, it is confusing and counting the stack makes my eyes cross. I'll say this, the intention of this test was to create the smallest stack that does not underflow when a missing immediate decodes to (1,29). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In writing a test case for this, the bytecode here seemed off. Is this what was meant here @jrhea ? 👀
edit: looking into this further tomorrow... closing for now