Update EIP-7708: clarify order of burn logs and coinbase transfer logs#11190
Update EIP-7708: clarify order of burn logs and coinbase transfer logs#11190eth-bot merged 11 commits intoethereum:masterfrom
Conversation
…n after payment to coinbase Payment to coinbase happens before selfdestructed accounts are removed in tx finalization. The order of the logs should reflect this.
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Pull request was closed
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
Hi, I had to refresh my knowledge of SELFDESTRUCT under EIP-6780 because I was convinced it did /not/ change any behavior when selfdestruct under same tx, but you are right, it actually does change some behavior (immediately burn instead of "at end of transaction")
Could you add these required EIPs:
EIP-4788 for system address
EIP-1559 for priority fee
EIP-6780 for selfdestruct in same transaction
Esp. EIP-6780 is important because without it, the emitted logs will change in the case selfdestruct to self.
Left some suggestions for clarity also.
Co-authored-by: Jochem Brouwer <[email protected]>
|
The commit 90204ec (as a parent of 1d12f5f) contains errors. |
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
4 participants
Payment to coinbase happens before selfdestructed accounts are removed in tx finalization. The order of the logs that are emitted should reflect this.