Update EIP-7708: Clarify transaction transfer to different account#11188
Conversation
Adds "to a different account" for transactions to match the existing CALL and SELFDESTRUCT behavior, making it explicit that self-transfers do not emit a transfer log.
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
|
Yes if we changed Before, the reason Now we are introducing conditionals and I just want to make sure this doesn't introduce unnecessary complexity and / or unexpected results but I think we're OK? Are there any legitimate cases where a non-zero self transfer would warrant a log / subscriber to such an event? |
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
I think this is the way. I can't really think of any case, even with some 7702 delegation, where this would be warranted to emit a log. I was just thinking out loud here 👍🏼
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Here, the reason was that SELFDESTRUCT immediately burns the ETH in case of a "self-transfer". |
Fix the self-destruct log. Implement ethereum/EIPs#11187 & ethereum/EIPs#11188. _Warning_: [[email protected]](https://github.com/ethereum/execution-spec-tests/releases/tag/bal%40v5.0.0) fixtures are not consistent with ethereum/EIPs#11187 & ethereum/EIPs#11188!
5 participants
Summary
Clarifies that a transfer log is only emitted for transactions when transferring to a different account.
This aligns with the existing behavior for
CALLandSELFDESTRUCTwhich already specify "to a different account".