Skip to content

CI: Fix EIPW check by merging ERCs prior to running#10140

Merged
SamWilsn merged 2 commits intoethereum:masterfrom
frangio:fix-walidator
Sep 23, 2025
Merged

CI: Fix EIPW check by merging ERCs prior to running#10140
SamWilsn merged 2 commits intoethereum:masterfrom
frangio:fix-walidator

Conversation

@frangio
Copy link
Copy Markdown
Contributor

@frangio frangio commented Aug 13, 2025

The current setup doesn't even allow mention of post-split ERCs.

I've added a merge of ERCs prior to running EIPW. Extracted the merge steps to a composite action since it's used in a few places.

@frangio frangio requested a review from eth-bot as a code owner August 13, 2025 13:11
@frangio frangio changed the title Fix EIPW step by merging prior to running Fix EIPW check by merging ERCs prior to running Aug 13, 2025
@eth-bot
Copy link
Copy Markdown
Collaborator

eth-bot commented Aug 13, 2025

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Aug 13, 2025
@eth-bot eth-bot changed the title Fix EIPW check by merging ERCs prior to running CI: Fix EIPW check by merging ERCs prior to running Aug 13, 2025
@g11tech
Copy link
Copy Markdown
Contributor

g11tech commented Aug 18, 2025

makes sense, will let @SamWilsn first give a thumbsup to the changes

Copy link
Copy Markdown

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SamWilsn SamWilsn merged commit 20917c1 into ethereum:master Sep 23, 2025
12 checks passed
@frangio frangio deleted the fix-walidator branch September 23, 2025 21:51
simonmasson pushed a commit to asanso/EIPs that referenced this pull request Oct 15, 2025
* Fix EIPW step by merging prior to running

* edit description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e-consensus Waiting on editor consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants