Skip to content

EIP 1010: Uniformity Between Two Addresses#1010

Merged
Arachnid merged 4 commits intoethereum:masterfrom
andywesley:master
Apr 19, 2018
Merged

EIP 1010: Uniformity Between Two Addresses#1010
Arachnid merged 4 commits intoethereum:masterfrom
andywesley:master

Conversation

@andywesley
Copy link
Contributor

@andywesley andywesley commented Apr 19, 2018

This pull request adds eip-draft_uniformity_between_0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B_and_0x15E55EF43efA8348dDaeAa455F16C43B64917e3c.md, a draft of an EIP titled "Uniformity Between 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B and 0x15E55EF43efA8348dDaeAa455F16C43B64917e3c". This is my first Ethereum proposal and I am open to constructive feedback.

…3259aeC9B_and_0x15E55EF43efA8348dDaeAa455F16C43B64917e3c.md
@andywesley
Copy link
Contributor Author

I am not sure why Travis CI failed, the output says:

Your test results are in. Everything looks fine.

but then says:

Liquid Exception: Liquid error (/home/travis/build/ethereum/EIPs/_includes/eiptable.html line 11): comparison of Array with Array failed included in all.html

I think this might fix the Travis CI build errors
@@ -0,0 +1,69 @@
---
eip: 1010
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file eip-1010.md (this will fix the build, too).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

---
eip: 1010
title: Uniformity Between 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B and 0x15E55EF43efA8348dDaeAa455F16C43B64917e3c
author: Anderson Wesley <@andywesley>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github usernames should be in (parentheses), not

eip: 1010
title: Uniformity Between 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B and 0x15E55EF43efA8348dDaeAa455F16C43B64917e3c
author: Anderson Wesley <@andywesley>
discussions-to: https://github.com/andywesley/EIPs/issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to specify a specific page to discuss. You can create an issue for this purpose if you wish.

…1C439e05C5B3259aeC9B_and_0x15E55EF43efA8348dDaeAa455F16C43B64917e3c.md to eip-1010.md
@andywesley andywesley changed the title EIP: Uniformity Between Two Addresses EIP 1010: Uniformity Between Two Addresses Apr 19, 2018
@andywesley
Copy link
Contributor Author

Thanks for the feedback, everything has been updated.

@Arachnid Arachnid merged commit 2f86b44 into ethereum:master Apr 19, 2018
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request May 2, 2018
* Create eip-draft_uniformity_between_0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B_and_0x15E55EF43efA8348dDaeAa455F16C43B64917e3c.md

* Fix typo

* Use pull request ID as tentative EIP

I think this might fix the Travis CI build errors

* Update and rename eip-draft_uniformity_between_0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B_and_0x15E55EF43efA8348dDaeAa455F16C43B64917e3c.md to eip-1010.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants