Documentation for representation classes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/coordinates/representations.rst
Outdated
Owner
There was a problem hiding this comment.
the "in ... inside ..." construction here is a bit confusing. Perhaps "the actual coordinate data in astropy.coordinates frames is represented via..."?
Owner
|
A few minor suggestions/doctest-related tweaks above, and one here, but the content looks great, @astrofrog!
|
Author
|
@eteq - I implemented the comments. For some reason I'm having issues running the doctests but should hopefully be ok. |
Owner
|
Yep, doctests now passing. Merging! Thanks @astrofrog |
eteq
added a commit
that referenced
this pull request
May 20, 2014
Documentation for representation classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eteq @Cadair - let me know if you have any suggestions!