Use Distroless as base image#13556
Conversation
Signed-off-by: yankay <[email protected]>
serathius
left a comment
There was a problem hiding this comment.
I haven't followed previous discussions about Etcd base image, however I'm fully supporting for switching to distroless image for security reasons.
ptabor
left a comment
There was a problem hiding this comment.
SGTM.
Could you please add it to changelog, as it might be important that some debugging tools will not be available within the image.
45e8346 to
94c426f
Compare
|
Thanks for comments, the message have been add to changelog
|
Signed-off-by: yankay <[email protected]>
94c426f to
3817521
Compare
ptabor
left a comment
There was a problem hiding this comment.
Thank you. Will merge when tests are green.
|
Hi @yank1 , I see that this changed the base image to |
|
It struck me when reading #14792. Busybox is a GPL licensed https://hub.docker.com/_/busybox https://www.busybox.net/license.html Not a expert, but I think there is a risk of etcd breaking busybox license by distributing docker image that busybox. My recommendation would be to remove it. Problem is that we backported this PR and released v3.4.23. I would recommend to remove/replace docker images. |
|
Thank you Marek, for spotting this. My thoughts are following:
|
I assume you were talking about #15017 or #15016
Shouldn't it be OK as long as etcd's an open source project?
The only impact would be that users can't log into a running container firstly and then execute command (e.g |
|
@serathius if etcd doesn't link to busybox, then it's fine |
|
FYI. #15037 |
Use Distroless as base image to reduce attack surface and image size.
Metioned by #13459 , #10804 and #10805 .
Signed-off-by: yankay [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.