[3.2 backport] pkg/fileutil: fix constant for linux locking#12553
Merged
ptabor merged 1 commit intoetcd-io:release-3.2from Jan 16, 2021
Merged
[3.2 backport] pkg/fileutil: fix constant for linux locking#12553ptabor merged 1 commit intoetcd-io:release-3.2from
ptabor merged 1 commit intoetcd-io:release-3.2from
Conversation
The constant F_OFD_GETLK is 36, not 37, according to /usr/include/bits/fcntl-linux.h Credits go to joakim-tjernlund who digged deep enough to find this. Fixes #31182
Contributor
|
In 3.4 and master (e.g. bea35fd) the constant was replaced with usage of constant from: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #12440 to release-3.3 branch, fixing the critical bug in pkg/fileutil. All credits to @moritzboth and @joakim-tjernlund. Original description follows.
The constant F_OFD_GETLK is 36, not 37, according to
/usr/include/bits/fcntl-linux.h
Credits go to @joakim-tjernlund who digged deep enough
to find this.