Address linter issues

henrybear327 · ivanvc · henrybear327 · commit 9b60c134ede4 · 2024-04-05T14:22:02.000+02:00
Changes (align with the main branch):
- remove rand.Seed(s)
- use rand.Read from "crypto/rand"
- add //nolint:all for (*reflect.SliceHeader)(slice) -&gt; will fix in a 
follow-up PR

Signed-off-by: Chun-Hung Tseng &lt;henrybear327@gmail.com&gt;
Co-authored-by: Iván Valdés Castillo &lt;iv@nvald.es&gt;
diff --git a/cmd/bbolt/main_test.go b/cmd/bbolt/main_test.go
@@ -3,7 +3,6 @@ package main_test
 import (
 	"bytes"
 	crypto "crypto/rand"
-	"encoding/binary"
 	"fmt"
 	"io"
 	"math/rand"
@@ -304,12 +303,6 @@ func NewMain() *Main {
 }
 
 func TestCompactCommand_Run(t *testing.T) {
-	var s int64
-	if err := binary.Read(crypto.Reader, binary.BigEndian, &s); err != nil {
-		t.Fatal(err)
-	}
-	rand.Seed(s)
-
 	dstdb := btesting.MustCreateDB(t)
 	dstdb.Close()
 
diff --git a/freelist_test.go b/freelist_test.go
@@ -320,7 +320,6 @@ func benchmark_FreelistRelease(b *testing.B, size int) {
 }
 
 func randomPgids(n int) []pgid {
-	rand.Seed(42)
 	pgids := make(pgids, n)
 	for i := range pgids {
 		pgids[i] = pgid(rand.Int63())
diff --git a/manydbs_test.go b/manydbs_test.go
@@ -1,8 +1,8 @@
 package bbolt
 
 import (
+	"crypto/rand"
 	"fmt"
-	"math/rand"
 	"os"
 	"path/filepath"
 	"testing"
@@ -46,7 +46,9 @@ func createAndPutKeys(t *testing.T) {
 			}
 
 			var key [16]byte
-			rand.Read(key[:])
+			if _, err := rand.Read(key[:]); err != nil {
+				return err
+			}
 			if err := nodes.Put(key[:], nil); err != nil {
 				return err
 			}
diff --git a/simulation_test.go b/simulation_test.go
@@ -35,8 +35,6 @@ func testSimulate(t *testing.T, openOption *bolt.Options, round, threadCount, pa
 		t.Skip("skipping test in short mode.")
 	}
 
-	rand.Seed(int64(qseed))
-
 	// A list of operations that readers and writers can perform.
 	var readerHandlers = []simulateHandler{simulateGetHandler}
 	var writerHandlers = []simulateHandler{simulateGetHandler, simulatePutHandler}
diff --git a/unsafe.go b/unsafe.go
@@ -32,7 +32,7 @@ func unsafeByteSlice(base unsafe.Pointer, offset uintptr, i, j int) []byte {
 // manipulation of reflect.SliceHeader to prevent misuse, namely, converting
 // from reflect.SliceHeader to a Go slice type.
 func unsafeSlice(slice, data unsafe.Pointer, len int) {
-	s := (*reflect.SliceHeader)(slice)
+	s := (*reflect.SliceHeader)(slice) //nolint:staticcheck
 	s.Data = uintptr(data)
 	s.Cap = len
 	s.Len = len

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,6 @@ func benchmark_FreelistRelease(b *testing.B, size int) {`
`320`	`320`	`}`
`321`	`321`
`322`	`322`	`func randomPgids(n int) []pgid {`
`323`		`- rand.Seed(42)`
`324`	`323`	`pgids := make(pgids, n)`
`325`	`324`	`for i := range pgids {`
`326`	`325`	`pgids[i] = pgid(rand.Int63())`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@ func testSimulate(t testing.T, openOption bolt.Options, round, threadCount, pa`
`35`	`35`	`t.Skip("skipping test in short mode.")`
`36`	`36`	`}`
`37`	`37`
`38`		`- rand.Seed(int64(qseed))`
`39`		`-`
`40`	`38`	`// A list of operations that readers and writers can perform.`
`41`	`39`	`var readerHandlers = []simulateHandler{simulateGetHandler}`
`42`	`40`	`var writerHandlers = []simulateHandler{simulateGetHandler, simulatePutHandler}`