source-stripe-native: dynamic subtask state initialization#2812
Conversation
|
@williamhbaker @Alex-Bair This PR is still in progress, however, I need to step away very soon for personal reasons and wanted to get any feedback while I am away. The PR is getting close, but I expect there to be holes poked in the approach and/or test cases I have or do not have. |
Alex-Bair
left a comment
Alex-Bair
left a comment
There was a problem hiding this comment.
Had a couple comments/questions. I'm sure you and Will have already talked about the approach, so feel free to update me if my comments go against something you guys have already discussed.
JustinASmith
force-pushed
the
js/dynamic-subtask-state
branch
from
88b08f8 to
33ea1e9
Compare
JustinASmith
changed the title
JustinASmith
force-pushed
the
js/dynamic-subtask-state
branch
3 times, most recently
from
a2a9f0b to
c8d11d7
Compare
Alex-Bair
left a comment
Alex-Bair
left a comment
There was a problem hiding this comment.
LGTM % a minor nit you could ignore if you want.
GitHub doesn't let me comment on the line, but a small nit is that it'd be a little clearer to me if the initialization of initial_state was before the open function definition. GPT is telling me that how it is now will work since initial_state is initialized before open is called, but my caveman brain doesn't realize that when initially glancing at the code.
|
@Alex-Bair thanks! My brain is all over the place. Working in the passenger seat of my car makes for a lot of distractions haha. I'll address this though and get it merged! |
JustinASmith
force-pushed
the
js/dynamic-subtask-state
branch
from
c8d11d7 to
a85acf3
Compare
3 participants
Description:
This pull request introduces changes to the
source-stripe-native/source_stripe_native/resources.pyfile to improve the initialization logic for resource state handling. The most notable updates include adding type annotations forall_bindings, introducing additional validation for state properties, and restructuring the logic for initializingfetch_changes_fnsandfetch_page_fns.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is