There's already #179 for BigInts (but I don't care which one is merged). I'm still in favor of not having value for them in the spec.

Because that was adding the spec into experimental directory, I have written this to move both syntaxes to es2020.md.

I prefer having value. The Literal node has value property, so the derived interface must have value property. We have experienced this behavior already when new syntaxes were added in RegExp. Indeed, nullable is odd, but I'm not worried because it's temporary.

@mysticatea In a bunch of places, you've mistyped BigInt as BitInt.

I'm leaning toward, we should change the representation of dynamic imports: #197.

What should I do to advance this PR?

@RReverser @ariya would you take a look this PR?

What should I do to advance this PR?

Are ther any more steps needed/revisions before this PR can be merged? Adding this in case this slipped

I am typing here as ESlint depends on this to get dynamic imports happening!

eslint/eslint#11803

any news?

@adrianheine Still would like your input on your PR vs this one.

I don't think we can land this as is. Unless I'm mistaken, both Webpack and Acorn have adopted the current experimental design for dynamic import. Seems it's too late and not worth the effort to undo the change. Just my 2 cents here.

I know Acorn's release was a mistake. I think they will make a major release after this PR merged. (acornjs/acorn#834 (comment))

@mysticatea and what about Webpack? This would need to get merged and released before Webpack 5 was released.

The AST was experimental. I believe we should fix it before getting stable, rather than leaving the pain for the future.

This would need to get merged and released before Webpack 5 was released.

I hope this PR to be merged as soon as possible. I have been waiting for the decide of ESTree team since a month ago. I'm just waiting.

ok, so:

Approvals needed:
[x] @mysticatea I suppose you serve as approval from the ESLint side of things.
[x] @RReverser speaks for Acorn.
[ ] @adrianheine still waiting on your approval as per @RReverser's comment.
[x] @michaelficarra you've reviewed. Would be nice to get an explicit approval from you.

People to inform:

• Pinging @sokra as a heads up that there will be an AST change coming up to hopefully get it into Webpack 5.
• And pinging @hzoo on the Babel side of things that this change is coming.

friendly ping @adrianheine

We have over a month (40 days) since the last commit. Is there any chance to be merged?

@RReverser I think we should merge this one and also credit @adrianheine in the commit message. The two pull requests are fundamentally the same thing (with respect to BigInt), no? Alternatively, we could land the dynamic import stuff (since we have wide agreement here), and slice off BigInt until Adrian replies.

Either way it's time to move this forward :-)

@RReverser once you're settled in at your new gig, perhaps you can merge this PR, or are we still waiting on anyone?

We have over two months since the last commit. Is there any chance to be merged?

Thanks @RReverser! @mysticatea do have any PRs open against Acorn acknowledging this change?

Thank you for merged!

Yes, I have acornjs/acorn#844

FYI, I've also pinged @sokra about the change so hopefully it can land in Acorn before Webpack 5.

Just for record keeping:
This has landed in Acorn 7.0.0 and will be in Webpack 5 alpha 21.