Edit intro section. Adjust/refine wording, but not the core themes.#1
Merged
esteban-url merged 2 commits intoesteban-url:test-in-github-actionsfrom Nov 22, 2022
keithtelliott:kte-test-in-github-actions
Merged
Edit intro section. Adjust/refine wording, but not the core themes.#1esteban-url merged 2 commits intoesteban-url:test-in-github-actionsfrom keithtelliott:kte-test-in-github-actions
esteban-url merged 2 commits intoesteban-url:test-in-github-actionsfrom
keithtelliott:kte-test-in-github-actions
Conversation
Collaborator
Author
|
@esteban-url I performed minor edits to the body of the article. Next up... Go-Do: I will actually step through the guide (I started, but need more time). Go-Do: Add concluding remarks at the end of the doc (me or you). |
esteban-url
approved these changes
Nov 22, 2022
Owner
|
Thank you so much for your help @keithtelliott! the edits are great! please let me know once you step through the guide, maybe it needs some refinement or further explanation. |
Owner
|
also, I've added you as a contributor on my repo, you should be able to create a PR directly on it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@esteban-url I climbing the GitHub learning curve. I have submitted my own PRs, but never have jumped into help with another PR. So, I'm figuring out the workflow.
I tried to push to your fork, but I'm getting 403 errors. So my latest attempt: Create my own fork, checkout your branch, rename it, push it to my forked repo, then submit a PR to you.
Is this how it should be done?
One day I'll know these GitHub flows :)