Skip to content

Added the DoIT ESPduino-32 board #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
me-no-dev merged 16 commits into from
Oct 3, 2020
Merged

Added the DoIT ESPduino-32 board #1520

me-no-dev merged 16 commits into from
Oct 3, 2020

Conversation

@alexceltare2
Copy link
Contributor

@alexceltare2 alexceltare2 commented Jun 21, 2018

Some pins missing but will finish as soon as I'm done researching it.

@alexceltare2
Copy link
Contributor Author

alexceltare2 commented Jun 27, 2018

IS someone going to approve the edit?

me-no-dev
me-no-dev requested changes Jun 28, 2018
View reviewed changes
@me-no-dev
Copy link
Member

me-no-dev commented Jun 28, 2018

Hi :) sorry for the late review. Please check the few notes that I left :)

@me-no-dev
Copy link
Member

me-no-dev commented Jul 10, 2018

hmm why are there merge conflicts? seems like some of my commits are also included?

@alexceltare2
Copy link
Contributor Author

alexceltare2 commented Oct 24, 2018

Alright Mr. me-no-dev. I've updated all it needs and followed the doitESP32devkitV1 model. Also, I've kept the boards.txt as the original as github seems to find conflicts if I change it.

alexceltare2
alexceltare2 commented Nov 3, 2018
View reviewed changes
Copy link
Contributor Author

@alexceltare2 alexceltare2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done

@alexceltare2 alexceltare2 changed the title Added the DoIT ESPduino-32 board, Added the DoIT ESPduino-32 board Nov 3, 2018
@atanisoft
Copy link
Collaborator

atanisoft commented Aug 16, 2019 •
edited
Loading

this is no longer necessary for merge as the d-duino-32 board is identical (and is the actual board that the DoIT ESPduino-32 board cloned)

@alexceltare2
Copy link
Contributor Author

alexceltare2 commented Aug 16, 2019

this is no longer necessary for merge as the d-duino-32 board is identical (and is the actual board that the DoIT ESPduino-32 board cloned)

WTF? d-duino-32 is a oled attached mini board with limited pin numbers whereas ESPduino-32 is a fully featured board what all pins exposed. Not even the pin markings are the same so your argument is invalid.

@atanisoft
Copy link
Collaborator

atanisoft commented Aug 16, 2019

d-duino-32 is a oled attached mini board with limited pin numbers whereas ESPduino-32

Sorry you are right, I did a quick search at the time and it came up as the same. Now looking again it is definitely different.

However, there are some pin mappings that are not correct on this board. A0 and A1 are mapped oddly to 2 and 4 so your pins_arduino.h should reflect this order on board (maybe even expose the A? constants?) I also don't see GPIO 0 exposed anywhere, where did you find it on the board?

@me-no-dev me-no-dev merged commit 3570d48 into espressif:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexceltare2 @me-no-dev @atanisoft