Defined BLE setAdvertisementType (#3535)

syonbori · me-no-dev · commit 915d45de7d41 · 2020-01-20T15:42:38.000+02:00
Currently we have no way to set BLE Advertisement Type. We have an initial value of ADV_TYPE_IND and the member is private. iBeacon should advertise with ADV_TYPE_NONCONN_IND. esp-idf's example code specifies this value. https://github.com/espressif/esp-idf/blob/93a8603c545fb8e54741d6685146e2f3b874378d/examples/bluetooth/bluedroid/ble/ble_ibeacon/main/ibeacon_demo.c#L57
diff --git a/libraries/BLE/examples/BLE_iBeacon/BLE_iBeacon.ino b/libraries/BLE/examples/BLE_iBeacon/BLE_iBeacon.ino
@@ -65,6 +65,7 @@ void setBeacon() {
   
   pAdvertising->setAdvertisementData(oAdvertisementData);
   pAdvertising->setScanResponseData(oScanResponseData);
+  pAdvertising->setAdvertisementType(ADV_TYPE_NONCONN_IND);
 
 }
 
diff --git a/libraries/BLE/src/BLEAdvertising.cpp b/libraries/BLE/src/BLEAdvertising.cpp
@@ -85,6 +85,10 @@ void BLEAdvertising::setAppearance(uint16_t appearance) {
 	m_advData.appearance = appearance;
 } // setAppearance
 
+void BLEAdvertising::setAdvertisementType(esp_ble_adv_type_t adv_type){
+	m_advParams.adv_type = adv_type;
+} // setAdvertisementType
+
 void BLEAdvertising::setMinInterval(uint16_t mininterval) {
 	m_advParams.adv_int_min = mininterval;
 } // setMinInterval
diff --git a/libraries/BLE/src/BLEAdvertising.h b/libraries/BLE/src/BLEAdvertising.h
@@ -52,6 +52,7 @@ class BLEAdvertising {
 	void start();
 	void stop();
 	void setAppearance(uint16_t appearance);
+	void setAdvertisementType(esp_ble_adv_type_t adv_type);
 	void setMaxInterval(uint16_t maxinterval);
 	void setMinInterval(uint16_t mininterval);
 	void setAdvertisementData(BLEAdvertisementData& advertisementData);
@@ -76,4 +77,4 @@ class BLEAdvertising {
 
 };
 #endif /* CONFIG_BT_ENABLED */
-#endif /* COMPONENTS_CPP_UTILS_BLEADVERTISING_H_ */
+#endif /* COMPONENTS_CPP_UTILS_BLEADVERTISING_H_ */

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ void setBeacon() {`
`65`	`65`
`66`	`66`	`pAdvertising->setAdvertisementData(oAdvertisementData);`
`67`	`67`	`pAdvertising->setScanResponseData(oScanResponseData);`
	`68`	`+ pAdvertising->setAdvertisementType(ADV_TYPE_NONCONN_IND);`
`68`	`69`
`69`	`70`	`}`
`70`	`71`