Conversation
replaces and closes #233
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2402 2412 +10
=========================================
+ Hits 2402 2412 +10 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 10, 2023
Member
Author
|
I've just finished the code for all 3 of these PRs. I'm doing testing aiohomekit and aioesphomeapi but I don't want to merge until I'm sure there won't be any breaking changes in the lib |
bdraco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Happy Eyeballs support (https://datatracker.ietf.org/doc/html/rfc8305)
--
This PR is a first step as I need to make sure this library works for the other projects as well. Its likely to sit for a bit while I test the library with all the projects that need it so there aren't any need to do breaking changes before all the other projects start consuming it:
--
replaces and closes #233