Skip to content

Conversation

@earlephilhower
Copy link
Collaborator

Fixes #8522

@earlephilhower earlephilhower marked this pull request as draft March 29, 2022 20:15
@earlephilhower
Copy link
Collaborator Author

I should also protect the SigningVerifier, so to draft for now.

@mcspr
Copy link
Collaborator

mcspr commented Mar 29, 2022

nit: unique_ptr will help, since we don't allow copies anyway and it handles free() and gets zeroed when when move happens

@earlephilhower earlephilhower marked this pull request as ready for review March 30, 2022 02:06
@earlephilhower earlephilhower requested a review from mcspr March 31, 2022 21:40
@mcspr
Copy link
Collaborator

mcspr commented Apr 7, 2022

idk what to answer for review, but 'it does not look simplified' :)
given the stability of the existing code (as it was the main argument from Matrix), we should probably rethink the overall structure instead of pushing certain features to the current one that make it more complicated instead of the opposite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception in X509List destructor due to invalid default copy assignment operator

2 participants