Update debugging.rst #5234
Merged
Update debugging.rst #5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLEASE REVIEW The current link definitely points to the wrong line, where there's nothing remotely resembling a list of DEBUG_ESP_* definitions. There's not an actual "full list" in the whole boards.txt really, but this is the closest thing that can be found in that file. Some additional explanation is needed though, unless there is an actual list somewhere else.
d-a-v
requested changes
Oct 12, 2018
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Please modify the link to point to relevant lines in ‘tools/boards.txt.py‘
d-a-v
requested changes
Oct 12, 2018
Contributor
|
This would be the link in boards.txt.py script: |
requested change
Contributor
Author
|
I think I have applied the requested change. Otherwise feel free (obviously) to change it yourself and reject this PR. |
d-a-v
approved these changes
Oct 12, 2018
Collaborator
|
Thanks @teo1978 ! |
suculent
pushed a commit
to thinx-cloud/Arduino
that referenced
this pull request
Oct 16, 2018
…Arduino into i2c_slave_by_bjoham * 'i2c_slave_by_bjoham' of https://github.com/thinx-cloud/Arduino: Update debugging.rst (esp8266#5234) ESP8266httpClient crash-on-destructor bugfix (esp8266#5220) Add stack repainting call to ESP class (esp8266#5221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE REVIEW
The current link definitely points to the wrong line, where there's nothing remotely resembling a list of DEBUG_ESP_* definitions. There's not an actual "full list" in the whole boards.txt file really, but this is the closest thing that can be found in that file.
Some additional explanation is needed though, unless there is an actual list and it's somewhere else.