Add full debug builds for all tests #5146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure the -DEBUG builds don't fail with checked-in code, add two jobs which build even/odd with full debug flags to Travis. Fixes esp8266#5143
earlephilhower
force-pushed
the
add_debug_ci
branch
from
b12cf1e to
aaccfc4
Compare
Collaborator
Author
|
As CI is "free" for now, no reason not to build everything with debugging enabled. If it becomes an issue, it is not a big change to pick specific tests to compile (but unless needed, I'd rather not try and guess what's needed for good coverage). |
earlephilhower
changed the title
earlephilhower
changed the title
d-a-v
reviewed
Sep 18, 2018
tests/common.sh
Outdated
| echo "compiler.c.extra_flags=-Wall -Werror" > esp8266/platform.local.txt | ||
| echo "compiler.cpp.extra_flags=-Wall -Werror" >> esp8266/platform.local.txt | ||
| echo "compiler.c.extra_flags=-Wall -Werror $debug_flags" > esp8266/platform.local.txt | ||
| echo "compiler.cpp.extra_flags=-Wall -Werror $debug_flags" >> esp8266/platform.local.txt |
Collaborator
There was a problem hiding this comment.
should -Wextrahave its place here too ?
Collaborator
Author
There was a problem hiding this comment.
Sure. It wasn't in the original "Add all warnings" patch but we can pull it in here...
d-a-v
approved these changes
Sep 18, 2018
devyte
approved these changes
Sep 21, 2018
Collaborator
devyte
left a comment
devyte
left a comment
There was a problem hiding this comment.
Given some of the CI run delays I've seen lately, this makes me cringe a bit, but it's absolutely needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure the -DEBUG builds don't fail with checked-in code, add
two jobs which build even/odd with full debug flags to Travis.
Fixes #5143