add http client configurable timeout usefull when download is slow on server side #4705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@igrr @me-no-dev @d-a-v can you provide some feedback |
d-a-v
approved these changes
May 3, 2018
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Out of curiosity how much do you use ?
Contributor
Author
|
@d-a-v I've put it to 30s since the wifi router signal is quite bad at my place. |
devyte
requested changes
May 3, 2018
|
|
||
| ESP8266HTTPUpdate::ESP8266HTTPUpdate(int httpClientTimeout) | ||
| { | ||
| this->_http_client_timeout = httpClientTimeout; |
Collaborator
There was a problem hiding this comment.
Please don't use constructor body for member init. Instead:
ESP8266HTTPUpdate::ESP8266HTTPUpdate(int httpClientTimeout)
: _http_client_timeout(httpClientTimeout)
{}
Contributor
Author
There was a problem hiding this comment.
done.thank you
| int _lastError; | ||
| bool _rebootOnUpdate = true; | ||
| private: | ||
| int _http_client_timeout; |
devyte
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fixes #1676 referenced on openenergymonitor/EmonESP#3 (fix stream error).