Skip to content

typo in define of USDTR; one of the bits of the UART status register in esp8266_peri.h #8584

@DarioGHub

Description

@DarioGHub

Basic Infos

  • This issue complies with the issue POLICY doc.
  • I have read the documentation at readthedocs and the issue is not addressed there.
  • I have tested that the issue is present in current master branch (aka latest git).
  • I have searched the issue tracker for a similar issue.
  • If there is a stack dump, I have decoded it.
  • I have filled out all fields below.

Platform

  • Hardware: [none]
  • Core Version: [b080c50]
  • Development Env: [Arduino IDE]
  • Operating System: [Windows]

Settings in IDE

  • Module: [Generic ESP8266 Module]
  • Flash Mode: [dout]
  • Flash Size: [1MB]
  • lwip Variant: [v2 Lower Memory]
  • Reset Method: [nodemcu]
  • Flash Frequency: [40Mhz]
  • CPU Frequency: [80Mhz]
  • Upload Using: [SERIAL]
  • Upload Speed: [115200] (serial upload only)

Problem Description

In esp8266_peri.h

#define U1S   ESP8266_REG(0xF1C) //STATUS
#define USDTR    39 //DTR PIN Level               <-- beyond the 4th byte (should be 29)

USDTR has been defined 39 as far back as 2015.

uart_register.h defines UART_DTRN as the intended bit 29.

#define UART_STATUS( i )                        (REG_UART_BASE( i ) + 0x1C)
#define UART_DTRN (BIT(29))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions