Skip to content

Add magic value for esp32c5 #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioGasquez merged 2 commits into from
Sep 18, 2025
Merged

Add magic value for esp32c5 #940

SergioGasquez merged 2 commits into from
Sep 18, 2025

Conversation

@CameronCTS
Copy link
Contributor

@CameronCTS CameronCTS commented Sep 10, 2025

Add 0x5fd1_406f as the magic value for identifying ESP32-C5. This value matches the value reported by my ESP32-C5. The attached image shows the result of running espflash board-info with the ESP32-C5 connected:

espflash

JurajSadel
JurajSadel approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

SergioGasquez
SergioGasquez reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you check the magic number of your device? Using the espflash logs? According to esp-serial-flasher the magic number is 0x1101406F

@CameronCTS
Copy link
Contributor Author

CameronCTS commented Sep 10, 2025

How did you check the magic number of your device? Using the espflash logs?

I ran espflash board-info using espflash 4.0.1 with my ESP32-C5-DevKitC-1 connected via USB and it reported an unknown magic value of 0x5fd1_406f.

SergioGasquez
SergioGasquez reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply! I did investigated a bit more and found out that it has several magic values, see https://github.com/espressif/esptool-js/blob/4d5231289af64659480c1119a0ba476c6cd402ea/src/targets/esp32c5.ts#L52, mind adding the other two?

Thanks!

@CameronCTS CameronCTS force-pushed the bugfix/esp32c5-magic-value branch from c4c3bd5 to b018b2f Compare September 16, 2025 01:58
SergioGasquez
SergioGasquez reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, could you add a changelog entry?? Thanks!

@SergioGasquez SergioGasquez added this pull request to the merge queue Sep 18, 2025
Merged via the queue into esp-rs:main with commit e320ae7 Sep 18, 2025
24 of 25 checks passed
@SergioGasquez
Copy link
Member

SergioGasquez commented Sep 18, 2025

Thanks for the contribution, since well release 4.1.0 I merged the PR as it is and added the changelog entry in #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioGasquez SergioGasquez SergioGasquez left review comments

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CameronCTS @SergioGasquez @JurajSadel