Indicate in CLI when a partition was skipped or being verified, fix incorrect chunk size being shown. #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Jun 30, 2025
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Very nice, thanks for this!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to extend #904 to utilize the "skipped" flag in CLI, show an example usage of the
verifyingsignal I suggested in the conversation in #794, and fix what I consider to be a (overall minor) mistake in #904.Screenshot:
Video Showcase for Verifying:
Screencast_20250627_183019.webm
Video Showcase for Skipping:
Screencast_20250627_182941.webm
In the past,
espflashseemed to pause for a moment during post-flash verification, and with #904, that was changed to add a ghost chunk to the reported total length of the segment that would be paused on during verification.I personally disagree with this specific change, since it also changes the reported output to users on how large their uploads are, and could potentially lead some to the wrong idea on why things are taking extra time. So I chose to make it much more clear as to what actions are being taken.
Before #904:
After #904:
(Note the +1 to each segment's reported length).