Move non-interactive flag to connect args #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
reviewed
Jun 26, 2025
Contributor
There was a problem hiding this comment.
I've tried to run some test locally:
./espflash/tests/scripts/save-image_write-bin.sh --port /dev/cu.usbmodem11401 --non-interactive esp32s3
error: unexpected argument '--port' found
tip: a similar argument exists: '--format'
Usage: espflash save-image --chip <CHIP> --merge --format <FORMAT> <IMAGE> <FILE>
For more information, try '--help'.
➜ espflash git:(1aa4970) ✗ ./espflash/tests/scripts/save-image_write-bin.sh -p /dev/cu.usbmodem11401 --non-interactive esp32s3
error: unexpected argument '-p' found
tip: to pass '-p' as a value, use '-- -p'
Usage: espflash save-image [OPTIONS] --chip <CHIP> <IMAGE> <FILE>
For more information, try '--help'.Am I missing something here?
EDIT: Solved offline, the correct way of running test locally:
ESPFLASH_PORT=/dev/cu.usbmodem11401 ./espflash/tests/scripts/save-image_write-bin.sh esp32s3
Contributor
I think this will be handy |
Member
Probably we can just filter the ports on macOS, e.g. to exclude |
SergioGasquez
force-pushed
the
fix/non-interactive
branch
from
2758442 to
d976b8f
Compare
MabezDev
reviewed
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
non-interactiveflag toConnectArgsso we also avoid asking the user to select a port. The logic added is the following: When usingnon-interactive, it will use any of the selected ports (via flag, environment variable or config file) and if no port was selected it will: Detect the number of ports, if there is only one, it will use this one, if there are multiple ports it will throw an error (MacOs usually duplicates ports so its not ideal, maybe we should error if >2 on macos?)