Remove chip target files #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'd appreciate some thorough testing on this PR, I moved a lot of things around, hopefully all correctly 😅. I'll add the changelog once we're happy with the changes. |
MabezDev
commented
Jun 18, 2025
| [SpiAttachParams::default(), SpiAttachParams::esp32_pico_d4()]; | ||
|
|
||
| /// Progress update callbacks | ||
| pub trait ProgressCallbacks { |
Member
Author
There was a problem hiding this comment.
Not sure if this belongs here either, but I think it's better than where it was
MabezDev
force-pushed
the
remove-targets
branch
2 times, most recently
from
9a8f939 to
12af73e
Compare
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Niice +789 −1,460, thanks! Left some thoughts/suggestions
SergioGasquez
approved these changes
Jun 19, 2025
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM once we update the changelog! Feel free to dedup or ignore my latest comment
| *.swp | ||
| .idea/ | ||
|
|
||
| !espflash/src/target |
Member
Author
There was a problem hiding this comment.
I had some fun with that initially :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestions 2 & 3 from #854 (comment)
As well as some minor refactoring and moving of various pieces to places that made more sense.