Fix baudrate #885
Merged
Fix baudrate #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
fix/change-baud
branch
from
949d5f1 to
dfae21a
Compare
SergioGasquez
force-pushed
the
fix/change-baud
branch
from
dfae21a to
775cf78
Compare
SergioGasquez
commented
Jun 16, 2025
| !no_verify, | ||
| !no_skip, | ||
| args.chip, | ||
| args.baud.or(config.project_config.baudrate), |
Member
Author
There was a problem hiding this comment.
This adds a weird arg to the flasher, but the other alternative was to have 2 getters in connection.
SergioGasquez
commented
Jun 16, 2025
Comment on lines
-709
to
-711
| if flasher.connection.baud() > 115_200 { | ||
| warn!("Setting baud rate higher than 115,200 can cause issues"); | ||
| flasher.change_baud(flasher.connection.baud())?; |
Member
Author
There was a problem hiding this comment.
This was causing the issue
MabezDev
reviewed
Jun 17, 2025
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
LGTM, should we add a change baud rate test?
SergioGasquez
force-pushed
the
fix/change-baud
branch
3 times, most recently
from
8376c94 to
46ea87d
Compare
SergioGasquez
force-pushed
the
fix/change-baud
branch
from
1a50404 to
3558ce8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/esp-rs/espflash/pull/882/files#diff-e53a42b9f8c1ec16423891fcffa2c2a2fda60d4a70f42ddb0771db4ad11b05c0R709-R711 introduced an issue where it would timeout if we try changing the baud to the same baud that is using.
Draft as I just noticed thatboard-infois not working as expected since #882, a 26MHz C2 is detected as 40MHzboard-infoand flashing (with a changed baudrate) should be working agai!