Move construction of Connection outside of flasher #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
approved these changes
Jun 13, 2025
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM once you add the changelog entry! Was there any reason to rename baud into speed? We use baudrate, baud_rate, baud and speed across the codebase.
Member
Author
I'll change it back to baud, and try and unify these. |
MabezDev
commented
Jun 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first suggestion from #854 (comment) and enables the creation of a
Connectionoutside ofFlasher::connect.In general this PR tries to keep the
Connectionspecific things, likesyncing, baud rate control, reset etc inConnectionand the flasher related things, like querying spi params, loading the flasher stub etc inFlasher.