Align segment lengths after merging #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
changed the title
bugadani
force-pushed
the
align
branch
3 times, most recently
from
a1e5327 to
1c8be30
Compare
jessebraham
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552 - the problem is that the reproducer elf has 2-byte aligned segments (functions in IRAM), and espflash used to 4-byte align segment lengths prematurely, causing them to overlap. This overlap then prevented merging segments, and the end result was an elf that the bootloader was not able to load.
The firmware seems to require some propriatery, or at least project-specific data to be present, so the firmware immediately panics, but it can boot with this PR.